Update to tinkerbell/tinkerbell/api for API definitions; Upgrade controller-runtime, CAPI, Go version, and all direct deps:
#468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
added
breaking-change
jacobweinstock
changed the title
tinkerbell/tinkerbell/api for API definitions; Upgrade controller-runtime and capi:tinkerbell/tinkerbell/api for API definitions; Upgrade controller-runtime, CAPI, Go version, and all direct deps:
jacobweinstock
removed
breaking-change
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Move to github.com/tinkerbell/tinkerbell/api: This is the new repo for all API definitions. Upgrade all go.mod dependencies: This uses the latest version of controller-runtime and capi. Fix kustomize files to remove deprecated fields: This gets Tilt and kustomize working properly. This was tested using the CAPT playground. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Move to a string instead of the deprecated capierrors.MachineStatusError. predicates.ClusterPausedTransitionsOrInfrastructureReady is the suggested function to use instead of the deprecated predicates.ClusterUnpausedAndInfrastructureReady. Signed-off-by: Jacob Weinstock <[email protected]>
The compatibility is being moved to each release. This is to help with keeping up the list. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Renaming to isoboot makes this mode name in line with netboot. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
This gets the project to the latest Tinkerbell, CAPI, and controller runtime versions. Signed-off-by: Jacob Weinstock <[email protected]>
The Tinkerbell CAPT playground has a command for performing the pivot process. This doc update details this process some. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
The only change is the annotation denoting the kubebuilder version. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
This gets the controller to work with the Helm charts <= 0.6.2 Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
This is needed for backward compatibility with Chart <= 0.6.2 Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
new-tinkerbell
branch
from
cb09131 to
ba68c6e
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the cluster-api-provider-tinkerbell to use the new centralized API definitions from github.com/tinkerbell/tinkerbell/api and upgrades all dependencies including controller-runtime, CAPI, and Go version. It also fixes deprecated kustomize configurations to work with modern tooling.
- Move API imports from separate
tinkandrufiorepos to unifiedtinkerbell/api - Upgrade Go from 1.23 to 1.24 and update all dependencies to latest versions
- Fix kustomize configurations by replacing deprecated fields with modern syntax
Reviewed Changes
Copilot reviewed 37 out of 38 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| main.go | Updated imports and scheme registration for new API structure |
| go.mod | Upgraded Go version and all dependencies to latest versions |
| controller/ | Updated all imports to use new unified API packages |
| config/ | Modernized kustomize configurations replacing deprecated syntax |
| api/v1beta1/ | Added new boot mode constants and updated webhook interfaces |
| Makefile | Updated tool versions and Go version references |
| @@ -143,22 +143,26 @@ func (scope *machineReconcileScope) reconcile(hw *tinkv1.Hardware) error { | |||
| return fmt.Errorf("ensure template and workflow returned: %w", err) | |||
| } | |||
|
|
|||
| if wf.Status.State == tinkv1.WorkflowStateFailed || wf.Status.State == tinkv1.WorkflowStateTimeout { | |||
| // STATE_* is needed for Helm charts <= 0.6.2 | |||
There was a problem hiding this comment.
[nitpick] This comment suggests temporary backward compatibility code. Consider adding a TODO or tracking issue to remove this compatibility code when support for older Helm charts is dropped.
Suggested change
| // STATE_* is needed for Helm charts <= 0.6.2 | |
| // TODO: Remove STATE_* compatibility when support for Helm charts <= 0.6.2 is dropped. See https://github.com/tinkerbell/cluster-api-provider-tinkerbell/issues/XXX |
Copilot uses AI. Check for mistakes.
Signed-off-by: Jacob Weinstock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to github.com/tinkerbell/tinkerbell/api: This is the new repo for all API definitions.
Upgrade all go.mod dependencies: This uses the latest version of controller-runtime and capi.
Fix kustomize files to remove deprecated fields: This gets Tilt and kustomize working properly. This was tested using the CAPT playground.
Why is this needed
Fixes: #
How Has This Been Tested?
Tested with the CAPT playground. Everything is successful. I tested with Tinkerbell stack v0.6.2 and the newest version, 0.19.3.
When using the Tinkerbell stack v0.6.2, the CAPT controller logs show some warning log lines. These do not impact operations. This is happening because the new Hardware object has a field (
spec.auto) that is not a pointer, so it gets included.{"level":"info","controller":"tinkerbellmachine","controllerGroup":"infrastructure.cluster.x-k8s.io","controllerKind":"TinkerbellMachine","TinkerbellMachine":{"name":"capt-playground-worker-a-b58xg-l9gr5","namespace":"tink"},"namespace":"tink","name":"capt-playground-worker-a-b58xg-l9gr5","reconcileID":"7a5e1b9f-6a1a-447d-a3ac-80a32ea2b1b7","v":0,"caller":"/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/log/warning_handler.go:64","time":"2025-08-11T23:26:21Z","message":"unknown field \"spec.auto\""}How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: